noblepaul commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1061964993
##########
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##########
@@ -139,30 +138,10 @@ public static String getCollectionPathRoot(String coll) {
* only a replica is updated
*/
public DocCollection copyWith(PerReplicaStates newPerReplicaStates) {
Review Comment:
The objective is to closely map the new design with the way objects are
created/modified/used
Before PRS, the `state.json` contained everything. So, once the `state.json`
is loaded `DocCollection`, `Slice`, `Replica` Objects remain immutable. After
PRS, that assumption is no longer true. The optimisation that we did in ZK
should reflect in the in memory structure as well.
> ... which is outside of the scope of Slice/Replica
Yes, the PRS data is itself outside the scope of `Slice`/`Replica`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
