[
https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655158#comment-17655158
]
David Smiley commented on SOLR-10466:
-------------------------------------
These are compatible ideas provided that the collection in the request is
optional so that my {{forCollection(...)}} idea can be used (if we like that
idea). There are *many* tests that produce requests without a collection. I
shudder to think of updating them all. And not just for the sake of _our_
tests; I think it's common.
A more radical alternative would be for SolrClient to produce builders on these
methods that must be completed (e.g. with "do()" or "req()" *instead of* taking
a request. This could address many concerns, including our current lack of
discoverability of the rich admin APIs. Probably too ambitious for now though
:)
Some of those SolrClient methods should probably just go away because they
don't deserve the ultra-convenience of a dedicated SolrClient method. I'm
thinking, {{{}optimize{}}}, {{{}rollback{}}}, maybe {{{}ping{}}}.
> setDefaultCollection should be deprecated in favor of SolrClientBuilder
> methods
> -------------------------------------------------------------------------------
>
> Key: SOLR-10466
> URL: https://issues.apache.org/jira/browse/SOLR-10466
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Assignee: Eric Pugh
> Priority: Minor
> Fix For: 7.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Now that builders are in place for {{SolrClients}}, the setters used in each
> {{SolrClient}} can be deprecated, and their functionality moved over to the
> Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice
> to have all the knobs, and levers used to tweak {{SolrClient}}s available in
> a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are
> mutable. Using some {{SolrClient}} setters can result in erratic and "trappy"
> behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the
> {{setDefaultCollection}} setter on all {{SolrClient}} implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
