magibney commented on code in PR #1279:
URL: https://github.com/apache/solr/pull/1279#discussion_r1063821975
##########
solr/core/src/java/org/apache/solr/util/CryptoKeys.java:
##########
@@ -295,15 +304,28 @@ public PublicKey getPublicKey() {
return publicKey;
}
- public byte[] encrypt(ByteBuffer buffer) {
Review Comment:
This is a public method on a public utility class though; I wonder if the
intention was to have this used flexibly from elsewhere? This could in
principle break plugin code ...
This change seems good still, but worth explicitly calling out this possible
concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
