janhoy commented on PR #1295: URL: https://github.com/apache/solr/pull/1295#issuecomment-1385290310
I also found that `security.js` redefined the global `$scope.permissions` also defined in `app.js` which holds a static map of all permission names. I renamed the variable to `$scope.permissionsConfig` to avoid this, although I cannot really find any direct use in html angular directives, so I think it caused no bugs. wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
