[ 
https://issues.apache.org/jira/browse/SOLR-16593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678330#comment-17678330
 ] 

Houston Putman commented on SOLR-16593:
---------------------------------------

[~noble.paul], these props have been there for a very long time. SOLR-15342 
just renamed some of the static variables. They have been there for at least 
2.5 years (didn't necessarily want to go further down the rabbit hole): 
https://github.com/heythm/solr/commit/a0488c1cf1be4f02f3b7b4494444345f506ace64#diff-3cf27848269b8f72d6270cb4e36892fd67a270ea09d1531e97a48ad7c8355419R319

How are you confident that these are not being used anywhere?

Also removing parts of the ZK State without a code review is pretty dangerous, 
can you please reach out asking for a +1 before doing it?

> Redundant fields are present in the replica object of state.json
> ----------------------------------------------------------------
>
>                 Key: SOLR-16593
>                 URL: https://issues.apache.org/jira/browse/SOLR-16593
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Major
>             Fix For: 9.2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The following is the new state,json
> {quote}{"shards":{"shard0":{
> "shard_range":"7c000000-7c1fffff",
> "replicas":{"core_node0":{
> "core":"replicacore",
> "leader":"true",
> "core_node_name":"test1_shard0_replica_n0",
> "node_name":"localhost:8983_solr",
> "base_url":"https://localhost";,
> "state":"active",
> "collection":"test1",
> "shard":"shard0",
> "type":"NRT",
> "force_set_state":"false"}},
> "state":"active"}}}
> {quote}
> The following fields are added and they look redundant to me
>  # "collection":"test1"
>  # "shard":"shard0"
>  # "core_node_name":"test1_shard0_replica_n0"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to