dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1080639405
##########
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##########
@@ -393,14 +393,22 @@ private SolrConfig(
}
private IndexSchemaFactory.VersionedConfig readXml(SolrResourceLoader
loader, String name) {
+ InputStream in = null;
try {
- ResourceProvider rp = new ResourceProvider(loader, name);
+ in = loader.openResource(name);
Review Comment:
Can we use try-with-resources pattern here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
