[
https://issues.apache.org/jira/browse/SOLR-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678433#comment-17678433
]
Michael Gibney commented on SOLR-16628:
---------------------------------------
Sure, thanks! There are some kinds of problems (and this may be one?) that
mainly manifest under load and are thus basically impossible to reproduce when
running a single test in isolation. I can sometimes reproduce such results more
efficiently by running something else at the same time that soaks up
threads/processors. Not to say that this would be a _replacement_ for running
the full test suite, but it might be a shortcut to figuring out whether this
patch makes a difference?
> Occasional resource leak around XmlConfigFile parsing
> ------------------------------------------------------
>
> Key: SOLR-16628
> URL: https://issues.apache.org/jira/browse/SOLR-16628
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 8.9
> Reporter: Michael Gibney
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, xml config file parsing can in exceptional circumstances lead to
> resource leaks (InputStream not being closed). This has occasionally [shown
> up in
> tests|https://issues.apache.org/jira/browse/SOLR-16336?focusedCommentId=17678323#comment-17678323]
> and presumably could also manifest in the wild.
> I suspect (but am not certain) that these changes may have been introduced in
> version 8.9 by SOLR-15337 (closing of byte streams in xml parsing is unusual
> iiuc in that according to spec, closing is handled internal to the parser, so
> it's easy to rely on that behavior and things will usually be ok. But we
> should take extra steps to ensure the InputStreams are always closed).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]