[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1307: Small code improvements in facet component

sonatype-lift Mon, 23 Jan 2023 02:36:28 -0800


sonatype-lift[bot] commented on code in PR #1307:
URL: https://github.com/apache/solr/pull/1307#discussion_r1083884241



##########
solr/core/src/java/org/apache/solr/response/GraphMLResponseWriter.java:
##########
@@ -20,41 +20,40 @@
 import java.io.IOException;
 import java.io.PrintWriter;
 import java.io.Writer;
-import java.util.List;
 import java.util.ArrayList;
-
+import java.util.List;
+import org.apache.solr.client.solrj.io.Tuple;
 import org.apache.solr.client.solrj.io.graph.Traversal;
 import org.apache.solr.client.solrj.io.stream.TupleStream;
-import org.apache.solr.client.solrj.io.Tuple;
 import org.apache.solr.handler.GraphHandler;
 import org.apache.solr.request.SolrQueryRequest;
 
-
 public class GraphMLResponseWriter implements QueryResponseWriter {
 
+  @Override
   public String getContentType(SolrQueryRequest req, SolrQueryResponse res) {
     return "application/xml";
   }
 
+  @Override
   public void write(Writer writer, SolrQueryRequest req, SolrQueryResponse 
res) throws IOException {
 
     Exception e1 = res.getException();
-    if(e1 != null) {
+    if (e1 != null) {
       e1.printStackTrace(new PrintWriter(writer));
       return;
     }
 
-    TupleStream stream =  (TupleStream)req.getContext().get("stream");
+    TupleStream stream = (TupleStream) req.getContext().get("stream");
 
-    if(stream instanceof GraphHandler.DummyErrorStream) {
-      GraphHandler.DummyErrorStream d = (GraphHandler.DummyErrorStream)stream;
+    if (stream instanceof GraphHandler.DummyErrorStream) {
+      GraphHandler.DummyErrorStream d = (GraphHandler.DummyErrorStream) stream;
       Exception e = d.getException();
       e.printStackTrace(new PrintWriter(writer));

Review Comment:
   <picture><img alt="0% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/0/display.svg";></picture>
   
   💬 8 similar findings have been found in this PR
   
   ---
   
   
*[INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE](https://find-sec-bugs.github.io/bugs.htm#INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE):*
  Possible information exposure through an error message
   
   ---
   
   <details><summary><b>🔎 Expand here to view all instances of this 
finding</b></summary><br/>
     
     
   <div align=\"center\">
   
   
   | **File Path** | **Line Number** |
   | ------------- | ------------- |
   | solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java | 
[589](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java#L589)
 |
   | solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/Tuple.java | 
[381](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/Tuple.java#L381)
 |
   | solr/core/src/java/org/apache/solr/response/GraphMLResponseWriter.java | 
[43](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/response/GraphMLResponseWriter.java#L43)
 |
   | solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java | 
[910](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java#L910)
 |
   | solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java | 
[1299](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java#L1299)
 |
   | 
solr/core/src/java/org/apache/solr/search/grouping/distributed/responseprocessor/SearchGroupShardResponseProcessor.java
 | 
[93](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/search/grouping/distributed/responseprocessor/SearchGroupShardResponseProcessor.java#L93)
 |
   | solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java | 
[124](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java#L124)
 |
   | solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java | 
[74](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java#L74)
 |
   <p><a 
href="https://lift.sonatype.com/results/github.com/apache/solr/01GQEZBSKB0V8KWDB2MGK5EH8N?t=FindSecBugs|INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE"
 target="_blank">Visit the Lift Web Console</a> to find more details in your 
report.</p></div></details>
   
   
   
   ---
   
   <details><summary><b>ℹ️ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=371756083&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756083&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756083&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756083&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=371756083&lift_comment_rating=5)
 ]



##########
solr/core/src/java/org/apache/solr/rest/ManagedResource.java:
##########
@@ -161,15 +151,13 @@ protected boolean updateInitArgs(NamedList<?> 
updatedArgs) {
     }
     boolean madeChanges = false;
     if (!managedInitArgs.equals(updatedArgs)) {

Review Comment:
   <picture><img alt="6% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg";></picture>
   
   💬 395 similar findings have been found in this PR
   
   ---
   
   *THREAD_SAFETY_VIOLATION:*  Read/Write race. Non-private method 
`ManagedResource.updateInitArgs(...)` reads without synchronization from 
`this.managedInitArgs`. Potentially races with write in method 
`ManagedResource.reloadFromStorage()`.
    Reporting because another access to the same memory occurs on a background 
thread, although this access may not.
   
   ---
   
   <details><summary><b>🔎 Expand here to view all instances of this 
finding</b></summary><br/>
     
     
   <div align=\"center\">
   
   
   | **File Path** | **Line Number** |
   | ------------- | ------------- |
   | solr/core/src/java/org/apache/solr/core/CoreContainer.java | 
[1235](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/core/CoreContainer.java#L1235)
 |
   | 
solr/modules/analytics/src/java/org/apache/solr/analytics/AnalyticsRequestManager.java
 | 
[250](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/modules/analytics/src/java/org/apache/solr/analytics/AnalyticsRequestManager.java#L250)
 |
   | solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java | 
[484](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java#L484)
 |
   | solr/core/src/java/org/apache/solr/update/DefaultSolrCoreState.java | 
[412](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/update/DefaultSolrCoreState.java#L412)
 |
   | solr/core/src/java/org/apache/solr/schema/IndexSchema.java | 
[1494](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/schema/IndexSchema.java#L1494)
 |
   | solr/core/src/java/org/apache/solr/update/TransactionLog.java | 
[275](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/update/TransactionLog.java#L275)
 |
   | 
solr/core/src/java/org/apache/solr/rest/schema/analysis/ManagedSynonymGraphFilterFactory.java
 | 
[303](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/rest/schema/analysis/ManagedSynonymGraphFilterFactory.java#L303)
 |
   | 
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java
 | 
[2150](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java#L2150)
 |
   | 
solr/core/src/java/org/apache/solr/rest/schema/analysis/ManagedSynonymFilterFactory.java
 | 
[316](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/rest/schema/analysis/ManagedSynonymFilterFactory.java#L316)
 |
   | solr/core/src/java/org/apache/solr/update/DefaultSolrCoreState.java | 
[254](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/update/DefaultSolrCoreState.java#L254)
 |
   <p> Showing <b>10</b> of <b> 395 </b> findings. <a 
href="https://lift.sonatype.com/results/github.com/apache/solr/01GQEZBSKB0V8KWDB2MGK5EH8N?t=Infer|THREAD_SAFETY_VIOLATION"
 target="_blank">Visit the Lift Web Console</a> to see all.</p></div></details>
   
   
   
   ---
   
   <details><summary><b>ℹ️ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=371756302&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756302&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756302&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756302&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=371756302&lift_comment_rating=5)
 ]



##########
solr/core/src/java/org/apache/solr/util/FileUtils.java:
##########
@@ -25,32 +25,26 @@
 import java.nio.channels.FileChannel;
 import java.nio.file.Files;
 import java.nio.file.Path;
-
 import org.apache.commons.io.FileExistsException;
 
-/**
- *
- */
+/** */
 public class FileUtils {
 
   /**
    * Resolves a path relative a base directory.
    *
-   * <p>
-   * This method does what "new File(base,path)" <b>Should</b> do, if it wasn't
-   * completely lame: If path is absolute, then a File for that path is 
returned;
-   * if it's not absolute, then a File is returned using "path" as a child
-   * of "base")
-   * </p>
+   * <p>This method does what "new File(base,path)" <b>Should</b> do, if it 
wasn't completely lame:
+   * If path is absolute, then a File for that path is returned; if it's not 
absolute, then a File
+   * is returned using "path" as a child of "base")
    */
   public static File resolvePath(File base, String path) {
     File r = new File(path);
     return r.isAbsolute() ? r : new File(base, path);
   }
 
-  public static void copyFile(File src , File destination) throws IOException {
+  public static void copyFile(File src, File destination) throws IOException {
     try (FileChannel in = new FileInputStream(src).getChannel();

Review Comment:
   <picture><img alt="11% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/11/display.svg";></picture>
   
   💬 23 similar findings have been found in this PR
   
   ---
   
   *RESOURCE_LEAK:*  resource of type `java.io.FileInputStream` acquired by 
call to `FileInputStream(...)` at line 46 is not released after line 46.
   **Note**: potential exception at line 47
   
   ---
   
   <details><summary><b>🔎 Expand here to view all instances of this 
finding</b></summary><br/>
     
     
   <div align=\"center\">
   
   
   | **File Path** | **Line Number** |
   | ------------- | ------------- |
   | solr/core/src/java/org/apache/solr/update/UpdateLog.java | 
[1402](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/update/UpdateLog.java#L1402)
 |
   | 
solr/core/src/java/org/apache/solr/update/processor/UpdateRequestProcessorChain.java
 | 
[184](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/update/processor/UpdateRequestProcessorChain.java#L184)
 |
   | solr/core/src/java/org/apache/solr/handler/GraphHandler.java | 
[124](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/handler/GraphHandler.java#L124)
 |
   | solr/test-framework/src/java/org/apache/solr/SolrTestCaseHS.java | 
[218](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/test-framework/src/java/org/apache/solr/SolrTestCaseHS.java#L218)
 |
   | solr/core/src/java/org/apache/solr/core/SolrCore.java | 
[2423](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/core/SolrCore.java#L2423)
 |
   | solr/core/src/java/org/apache/solr/update/UpdateLog.java | 
[1409](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/update/UpdateLog.java#L1409)
 |
   | solr/core/src/java/org/apache/solr/core/PluginBag.java | 
[148](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/core/PluginBag.java#L148)
 |
   | solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java | 
[362](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java#L362)
 |
   | solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java | 
[125](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java#L125)
 |
   | solr/core/src/java/org/apache/solr/handler/BlobHandler.java | 
[335](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/handler/BlobHandler.java#L335)
 |
   <p> Showing <b>10</b> of <b> 23 </b> findings. <a 
href="https://lift.sonatype.com/results/github.com/apache/solr/01GQEZBSKB0V8KWDB2MGK5EH8N?t=Infer|RESOURCE_LEAK"
 target="_blank">Visit the Lift Web Console</a> to see all.</p></div></details>
   
   
   
   ---
   
   <details><summary><b>ℹ️ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=371756313&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756313&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756313&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756313&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=371756313&lift_comment_rating=5)
 ]



##########
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##########
@@ -98,37 +93,55 @@ public void close() throws IOException {
   public void uninstall(String packageName, String version) {
     SolrPackageInstance packageInstance = getPackageInstance(packageName, 
version);
     if (packageInstance == null) {
-      PackageUtils.printRed("Package " + packageName + ":" + version + " 
doesn't exist. Use the install command to install this package version first.");
+      PackageUtils.printRed(
+          "Package "
+              + packageName
+              + ":"
+              + version
+              + " doesn't exist. Use the install command to install this 
package version first.");
       System.exit(1);
     }
 
     // Make sure that this package instance is not deployed on any collection
     Map<String, String> collectionsDeployedOn = 
getDeployedCollections(packageName);
-    for (String collection: collectionsDeployedOn.keySet()) {
+    for (String collection : collectionsDeployedOn.keySet()) {
       if (version.equals(collectionsDeployedOn.get(collection))) {
-        PackageUtils.printRed("Package " + packageName + " is currently 
deployed on collection: " + collection + ". Undeploy the package with undeploy 
<package-name> -collections <collection1>[,<collection2>,...] before attempting 
to uninstall the package.");
+        PackageUtils.printRed(
+            "Package "
+                + packageName
+                + " is currently deployed on collection: "
+                + collection
+                + ". Undeploy the package with undeploy <package-name> 
-collections <collection1>[,<collection2>,...] before attempting to uninstall 
the package.");
         System.exit(1);
       }
     }
 
-    // Make sure that no plugin from this package instance has been deployed 
as cluster level plugins
+    // Make sure that no plugin from this package instance has been deployed 
as cluster level
+    // plugins
     Map<String, SolrPackageInstance> clusterPackages = 
getPackagesDeployedAsClusterLevelPlugins();
-    for (String clusterPackageName: clusterPackages.keySet()) {
+    for (String clusterPackageName : clusterPackages.keySet()) {
       SolrPackageInstance clusterPackageInstance = 
clusterPackages.get(clusterPackageName);

Review Comment:
   <picture><img alt="16% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/16/display.svg";></picture>
   
   💬 23 similar findings have been found in this PR
   
   ---
   
   *INEFFICIENT_KEYSET_ITERATOR:*  Accessing a value using a key that was 
retrieved from a `keySet` iterator. It is more efficient to use an iterator on 
the `entrySet` of the map, avoiding the extra `HashMap.get(key)` lookup.
   
   ---
   
   <details><summary><b>🔎 Expand here to view all instances of this 
finding</b></summary><br/>
     
     
   <div align=\"center\">
   
   
   | **File Path** | **Line Number** |
   | ------------- | ------------- |
   | solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java | 
[253](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java#L253)
 |
   | solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java | 
[202](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java#L202)
 |
   | solr/core/src/java/org/apache/solr/util/PackageTool.java | 
[127](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/util/PackageTool.java#L127)
 |
   | solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java | 
[314](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java#L314)
 |
   | solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java | 
[108](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java#L108)
 |
   | solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java | 
[295](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java#L295)
 |
   | solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java | 
[312](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java#L312)
 |
   | solr/core/src/java/org/apache/solr/handler/ClusterAPI.java | 
[151](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/handler/ClusterAPI.java#L151)
 |
   | 
solr/core/src/java/org/apache/solr/rest/schema/analysis/ManagedSynonymFilterFactory.java
 | 
[223](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/rest/schema/analysis/ManagedSynonymFilterFactory.java#L223)
 |
   | solr/core/src/java/org/apache/solr/util/PackageTool.java | 
[143](https://github.com/apache/solr/blob/a33ba6bb6cf2e46fb136f879a6bc5696b8f779d8/solr/core/src/java/org/apache/solr/util/PackageTool.java#L143)
 |
   <p> Showing <b>10</b> of <b> 23 </b> findings. <a 
href="https://lift.sonatype.com/results/github.com/apache/solr/01GQEZBSKB0V8KWDB2MGK5EH8N?t=Infer|INEFFICIENT_KEYSET_ITERATOR"
 target="_blank">Visit the Lift Web Console</a> to see all.</p></div></details>
   
   
   
   ---
   
   <details><summary><b>ℹ️ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=371756319&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756319&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756319&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=371756319&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=371756319&lift_comment_rating=5)
 ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1307: Small code improvements in facet component

Reply via email to