epugh commented on code in PR #1304:
URL: https://github.com/apache/solr/pull/1304#discussion_r1084211406
##########
solr/webapp/web/js/angular/controllers/analysis.js:
##########
@@ -21,33 +21,64 @@ solrAdminApp.controller('AnalysisController',
$scope.refresh = function() {
Luke.schema({core: $routeParams.core}, function(data) {
- $scope.fieldsAndTypes = [];
- for (var field in data.schema.fields) {
- $scope.fieldsAndTypes.push({
- group: "Fields",
- value: "fieldname=" + field,
- label: field});
- }
- for (var type in data.schema.types) {
- $scope.fieldsAndTypes.push({
- group: "Types",
- value: "fieldtype=" + type,
- label: type});
- }
+ $scope.fieldsAndTypes = getFieldsAndTypes(data.schema);
$scope.core = $routeParams.core;
+ $scope.parseQueryString(data.schema);
+ // @todo - set defaultSearchField either to
context["analysis.fieldname"] or context["analysis.fieldtype"]
Review Comment:
Cool, what prompted this? I guess I am wondering if we need this? I am
playing with the code, and it *appears* to all work ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
