gerlowskija commented on code in PR #1314:
URL: https://github.com/apache/solr/pull/1314#discussion_r1089096003
##########
solr/core/src/java/org/apache/solr/jersey/InjectionFactories.java:
##########
@@ -62,6 +65,25 @@ public SolrQueryResponse provide() {
public void dispose(SolrQueryResponse instance) {}
}
+ /** Fetch the (existing) SolrCore from the request context */
+ public static class SolrCoreFactory implements Factory<SolrCore> {
Review Comment:
I'd like to keep "Factory" in there because it's implementing a Factory
interface, but I agree the overloading of that term is unfortunate.
I can tweak the name so that it's clearer that this doesn't actually
construct new SolrCore's though. That should help I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
