dsmiley commented on code in PR #1267:
URL: https://github.com/apache/solr/pull/1267#discussion_r1090070741
##########
solr/core/src/java/org/apache/solr/cloud/Overseer.java:
##########
@@ -199,9 +199,15 @@ private class ClusterStateUpdater implements Runnable,
Closeable {
private SolrMetricsContext clusterStateUpdaterMetricContext;
+ private final int minimumStateSizeForCompression;
Review Comment:
You didn't supply a reason why "size" is better than "bytes". I gave a
reason why "bytes" is better.
Other idea is "ByteLen".
Agreed on "min" vs "minimum".
Note that if we ultimately land on a unit ambiguous name (as is right now),
the very least we could do is add a line of docs to specify the unit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
