dsmiley commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1090073203
##########
solr/core/build.gradle:
##########
@@ -115,6 +115,8 @@ dependencies {
implementation 'commons-cli:commons-cli'
+ implementation 'net.jcip:jcip-annotations'
Review Comment:
These two JARs are equivalent but have different licenses. We should prefer
`stephenc` as it's ASL licensed; a clean-room written implementation. The
net.jcip https://jcip.net/annotations/doc/index.html is using Creative Commons
Attribution License (http://creativecommons.org/licenses/by/2.5) which the ASF
is okay with in binary form https://www.apache.org/legal/resolved.html#cc-by
but lets prefer the ASL one as we have a choice.
I removed net.jcip in #1313 this weekend; pending merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
