magibney commented on PR #1320: URL: https://github.com/apache/solr/pull/1320#issuecomment-1410950319
btw I wasn't intending to throw the scope of this PR by mentioning extracting `gradle.properties` generation into the gradlew script. I think it's still an open question whether it makes sense to pursue that. But it definitely makes sense to fix the circular dependency (as you did in aabacb56472acb573ad60b8b5d21913e3a8d0af5). Maybe it'd make sense to proceed with a different PR for the gradlew script quesiton? (sorry for the mixed messages). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
