[
https://issues.apache.org/jira/browse/SOLR-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684931#comment-17684931
]
David Smiley commented on SOLR-16623:
-------------------------------------
More comments:
* Scope to SolrJettyTestBase without modifying tests using it because there
are a great many and I want to reduce risks of this not getting done. This
means keeping its API that tests use, and sadly keeping some static fields.
* SJTB closes Jetty and some SolrClients. But since we're extracting out a
Rule, that job will be for the Rule to do (obviously).
* Let's use this TestRule somewhere else in addition. LargeVolumeJettyTest
would make sense to remedy the fact that it's no longer using Jetty (ouch!).
> SolrClientTestRule for JettySolrRunner
> --------------------------------------
>
> Key: SOLR-16623
> URL: https://issues.apache.org/jira/browse/SOLR-16623
> Project: Solr
> Issue Type: Sub-task
> Components: Tests
> Reporter: David Smiley
> Priority: Minor
>
> (Sub-Task) Add a subclass of SolrClientTestRule (created in a sibling issue)
> for JettySolrRunner. Convert SolrJettyTestBase to use it, which contains
> some useful logic already that might migrate into such a rule.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
