dsmiley commented on code in PR #1341:
URL: https://github.com/apache/solr/pull/1341#discussion_r1103736776
##########
solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java:
##########
@@ -106,39 +108,16 @@ public static JettySolrRunner createAndStartJetty(String
solrHome) throws Except
public static JettySolrRunner createAndStartJetty(
String solrHome, Properties nodeProperties, JettyConfig jettyConfig)
throws Exception {
- initCore(null, null, solrHome);
-
- Path coresDir = createTempDir().resolve("cores");
-
- Properties props = new Properties();
- props.setProperty("name", DEFAULT_TEST_CORENAME);
- props.setProperty("configSet", "collection1");
- props.setProperty("config", "${solrconfig:solrconfig.xml}");
- props.setProperty("schema", "${schema:schema.xml}");
-
- writeCoreProperties(coresDir.resolve("core"), props, "RestTestBase");
-
- Properties nodeProps = new Properties(nodeProperties);
- nodeProps.setProperty("coreRootDirectory", coresDir.toString());
- nodeProps.setProperty("configSetBaseDir", solrHome);
-
- jetty = new JettySolrRunner(solrHome, nodeProps, jettyConfig);
- jetty.start();
- port = jetty.getLocalPort();
- log.info("Jetty Assigned Port#{}", port);
+ solrClientTestRule.startSolr(Path.of(solrHome));
Review Comment:
This is a persistent false-positive that I'm pursuing some resolution with
Lift/Infer/RacerD. Just ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
