epugh commented on code in PR #1206:
URL: https://github.com/apache/solr/pull/1206#discussion_r1103813444
##########
solr/core/src/test/org/apache/solr/cloud/OverseerTest.java:
##########
@@ -127,7 +127,6 @@ public class OverseerTest extends SolrTestCaseJ4 {
private final List<UpdateShardHandler> updateShardHandlers =
Collections.synchronizedList(new ArrayList<>());
private final List<CloudSolrClient> solrClients =
Collections.synchronizedList(new ArrayList<>());
- private static final String COLLECTION =
SolrTestCaseJ4.DEFAULT_TEST_COLLECTION_NAME;
Review Comment:
Same argument as above... If we learn, reading the tests, taht
DEFAULT_TEST_COLLECTION_NAME means that the test using the default collection
name, and that you don't need to think about it, then let's use that name
everywhere...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
