dsmiley commented on PR #1206: URL: https://github.com/apache/solr/pull/1206#issuecomment-1427305696
l'll add a disclaimer that, I've observed to some developers, use of constants is like some sort of religion. I am most definitely *not* religious about any coding practice. I think sometimes constants are a needless indirection to discern a value (not very relevant to this PR) and sometimes a bit more verbose as well. Yet another import statement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
