epugh commented on code in PR #1338:
URL: https://github.com/apache/solr/pull/1338#discussion_r1104444472
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java:
##########
@@ -101,13 +116,27 @@ public B withConnectionTimeout(int
connectionTimeoutMillis) {
* sockets.
*
* <p>For valid values see {@link
org.apache.http.client.config.RequestConfig#getSocketTimeout()}
+ *
+ * <p>* @deprecated Please use {@link #withSocketTimeout(long, TimeUnit)}
*/
+ @Deprecated(since = "9.2")
public B withSocketTimeout(int socketTimeoutMillis) {
+ withSocketTimeout(connectionTimeoutMillis, TimeUnit.MILLISECONDS);
Review Comment:
OMG... For some reason I was locked into looking for red underlines from
intellij, and never even thought about this. In my other branch, I think I did
the exact same thing again...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
