epugh commented on code in PR #1338:
URL: https://github.com/apache/solr/pull/1338#discussion_r1105781681
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##########
@@ -232,32 +232,32 @@ void evictStale() {
*/
@Deprecated
public void setRetryExpiryTime(int secs) {
- this.retryExpiryTime = TimeUnit.NANOSECONDS.convert(secs,
TimeUnit.SECONDS);
+ this.retryExpiryTimeNano = TimeUnit.NANOSECONDS.convert(secs,
TimeUnit.SECONDS);
}
protected final StateCache collectionStateCache = new StateCache();
class ExpiringCachedDocCollection {
final DocCollection cached;
- final long cachedAt;
+ final long cachedAtNano;
// This is the time at which the collection is retried and got the same
old version
- volatile long retriedAt = -1;
+ volatile long retriedAtNano = -1;
// flag that suggests that this is potentially to be rechecked
volatile boolean maybeStale = false;
ExpiringCachedDocCollection(DocCollection cached) {
this.cached = cached;
- this.cachedAt = System.nanoTime();
+ this.cachedAtNano = System.nanoTime();
}
boolean isExpired(long timeToLiveMs) {
- return (System.nanoTime() - cachedAt)
+ return (System.nanoTime() - cachedAtNano)
Review Comment:
i did a pass, but it looked a bit odd, and I'm worried about introducing a
bug.. so I backed it out. But it does point to do we need a pass through Solr
codebase and try and get all our time handling variables names and
initialization patterns to be the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
