cpoerschke commented on code in PR #937:
URL: https://github.com/apache/solr/pull/937#discussion_r1114585921
##########
solr/modules/ltr/src/java/org/apache/solr/ltr/interleaving/LTRInterleavingScoringQuery.java:
##########
@@ -25,7 +26,7 @@
public class LTRInterleavingScoringQuery extends LTRScoringQuery {
// Model was picked for this Docs
- private Set<Integer> pickedInterleavingDocIds;
+ private Set<Integer> pickedInterleavingDocIds = Collections.emptySet();
Review Comment:
This seems to be another way to avoid the NPE (thanks for adding the tests!)
and it would remove the need for `*TransformerFactory` changes ...
Though maybe it's a bit unconventional/controversial to initialise like
this? What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
