[ 
https://issues.apache.org/jira/browse/SOLR-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692670#comment-17692670
 ] 

Jan Høydahl commented on SOLR-16488:
------------------------------------

The path {{/api/cluster/zookeeper/files/<zkPath>/children}} pattern sounds 
scary, as <zkPath> may accidentally end with the word "children", as in 
{{{}/configs/children{}}}. So perhaps we should have some kind of convention, 
like {{_children}} which would be reserved for routing, not data? The old 
format {{/api/cluster/zk/data/...}} did not suffer from this ambiguity. It is 
not forbidden to use GET params with REST either... 
{{api/cluster/zookeeper/files?path=<zkPath>}} vs 
{{api/cluster/zookeeper/files/children?path=<zkPath>}}.

As for the old {{/admin/zookeeper}} it is soo different from the new and will 
take lots of effort to move the Admin UI over. So I'd argue treating it as a 
separate API and just give it another name in V2 namespace, like 
{{/api/cluster/zookeeper/tree}}. Also the {{/admin/zookeeper/status}} could be 
{{/api/cluster/zookeeper/status}}?

> Migrate ZookeeperReadAPI to JAX-RS
> ----------------------------------
>
>                 Key: SOLR-16488
>                 URL: https://issues.apache.org/jira/browse/SOLR-16488
>             Project: Solr
>          Issue Type: Sub-task
>          Components: v2 API
>    Affects Versions: 9.1, main (10.0)
>            Reporter: Jason Gerlowski
>            Assignee: Jason Gerlowski
>            Priority: Major
>              Labels: newdev
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> EDIT: This description originally described creating a plan for creating v2 
> APIs equivalent to the current v1 /admin/zookeeper endpoints.  But it turns 
> out that equivalent v2 APIs already largely exist in ZookeeperReadAPI.  The 
> description has updated to reflect this.
> The ZookeeperReadAPI APIs should be migrated to JAX-RS and be tweaked to be 
> more REST-ful and in line with the direction we're pushing v2 in.  See the 
> comments below for a discussion of specific tweaks to the HTTP path, 
> parameters, etc. for these APIs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to