uschindler commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1125416518
##########
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##########
@@ -63,7 +63,7 @@ protected Directory create(String path, LockFactory
lockFactory, DirContext dirC
throws IOException {
MMapDirectory mapDirectory = new MMapDirectory(Path.of(path), lockFactory,
maxChunk);
try {
- mapDirectory.setUseUnmap(unmapHack);
+ System.setProperty(MMapDirectory.ENABLE_UNMAP_HACK_SYSPROP,
String.valueOf(unmapHack));
Review Comment:
No not in create().
On init() just check for existence of directory property "unmap", if it
exists show exactly this warning. Maybe add something "Per directory unmapping
is no longer supported with Lucene 9.5. ...."
If user does not specify anything in the XML file, no warning is printed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
