janhoy commented on PR #1436: URL: https://github.com/apache/solr/pull/1436#issuecomment-1458851720
Lucene uses `GITHUB#123` for their CHANGES github links. But I like `PR#123` better as it is shorter and should be well understood. In the `changes2html` script I added support for both `GITHUB#123`, `GH#123` and `PR#123`. I also considered a plain `#123` or `(#123)`, which is a pretty standard way of linking to github issue or PR. I really like the plain `#123` best, as it should be well understood by developers too. However, as long as we have both JIRA and GH it may be ambigous to read "number 123" and assume it is Github. Shout out if you have strong opinions either way. @HoustonPutman may will cause some merge conflicts for other in-flight PRs, and will also need syncing with branch_9x, which happens to be a release manager task that needs doing anyway. So if you want to take over this PR and finalize it as part of your RM task, that is OK with me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
