risdenk commented on code in PR #1443:
URL: https://github.com/apache/solr/pull/1443#discussion_r1129838584
##########
solr/core/src/test/org/apache/solr/handler/TestHttpRequestId.java:
##########
@@ -126,7 +116,7 @@ public void onFailure(Throwable throwable) {
assertEquals(3, reqLog.getQueue().size());
while (!reqLog.getQueue().isEmpty()) {
var reqEvent = reqLog.getQueue().poll();
- assertTrue(reqEvent.getContextData().containsKey(key));
+ assertNotNull(reqEvent);
Review Comment:
the check is that reqEvent could be null from the poll(). I'm going to push
a quick addendum quick to remove the repeated `reqLog.getQueue` which then
doesn't need the null check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
