hiteshk25 commented on code in PR #1438:
URL: https://github.com/apache/solr/pull/1438#discussion_r1132905423
##########
solr/core/src/java/org/apache/solr/cloud/overseer/ZkStateWriter.java:
##########
@@ -139,8 +139,12 @@ public ClusterState enqueueUpdate(
throw new IllegalStateException(
"ZkStateWriter has seen a tragic error, this instance can no longer
be used");
}
- if (cmds.isEmpty()) return prevState;
- if (isNoOps(cmds)) return prevState;
+ if (cmds.isEmpty() || isNoOps(cmds)) { // empty and no-ops are valid,
should call callback
+ if (callback != null) {
Review Comment:
Thanks @patsonluk. is it possible to add unit test for this method
`enqueueUpdate` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
