Fikavec commented on code in PR #1440:
URL: https://github.com/apache/solr/pull/1440#discussion_r1136208405
##########
solr/core/src/java/org/apache/solr/response/JacksonJsonWriter.java:
##########
@@ -29,6 +29,16 @@
import org.apache.solr.request.SolrQueryRequest;
public class JacksonJsonWriter extends BinaryResponseWriter {
+
+ protected final JsonFactory jsonfactory;
Review Comment:
`protected static final JsonFactory jsonfactory = new JsonFactory();`
I'm sorry, maybe it would be better to create a factory right here than
in the constructor (just like you did with "PrettyPrinter pretty = ")? Then the
"public JacksonJsonWriter(){super()..." constructor itself can be deleted
below, since it will no longer be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
