risdenk commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1142246317


##########
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##########
@@ -1221,7 +1217,7 @@ public Elevation(Set<BytesRef> elevatedIds, Set<BytesRef> 
excludedIds, String qu
         includeQuery = EMPTY_QUERY;
         this.elevatedIds = Collections.emptySet();
       } else {
-        this.elevatedIds = ImmutableSet.copyOf(elevatedIds);
+        this.elevatedIds = Set.copyOf(elevatedIds);

Review Comment:
   The issue is here :( `ImmutableSet.copyOf` keeps things in order it looks 
like. `Set.copyOf` doesn't care.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to