[
https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703368#comment-17703368
]
Jason Gerlowski commented on SOLR-16393:
----------------------------------------
I've started working on it, thanks for checking in. (I put my name in the
"Volunteer" column for it up in the issue description but I bet it got lost in
the noise. I should've called it out in a comment.)
The PR is [here|https://github.com/apache/solr/pull/1453]. My thought in that
PR is to bundle together a handful of APIs that share a bunch of similar params
- particularly the parameters that Solr accepts upon collection-creation.
Those get used by the collection-creation API obviously, but they're also
accepted by create-alias and restore-collection, since those can both
implicitly create collections themselves.
It's still early days in that PR - but I'd love a review there if you have a
few minutes?
Thanks to your work on the alias prop APIs, create-alias is the last bit of
this ticket that's still outstanding. But if you're interested in helping with
a few more there are tons remaining on other tickets! SOLR-15781 is a parent
ticket that aims to encapsulate both the cosmetic changes and JAX-RS
conversion. Feel free to grab anything there that interests you.
(Alternately, if you want to do something but aren't sure how to pick,
SOLR-16392 is another ticket we're close-ish to getting closed out. Might make
sense to focus efforts on there to get it over the line.)
> Cosmetic improvements and migration to JAX-RS (alias, alias-prop CRUD APIs)
> ---------------------------------------------------------------------------
>
> Key: SOLR-16393
> URL: https://issues.apache.org/jira/browse/SOLR-16393
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Major
> Labels: newdev
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> As mentioned on SOLR-15781, the v2 API currently has an experimental
> designation, and the community has expressed an interest in using this period
> to update our v2 endpoints to be more REST-ful and consistent. The current
> plan is to follow the specific changes laid out in [this
> spreadsheet|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing],
> though of course nothing there is set in stone and there are still warts to
> be worked out.
> While we're touching the code for these endpoints, we should also convert
> them to JAX-RS framework definitions. (This was initially tracked as a
> separate effort - see SOLR-16370 - but the edit that were required ended up
> overlapping so significantly with the "cosmetic" improvements here that in
> practice it almost always makes sense to do the two together.)
> This ticket plans to tackle making the changes required for Solr's alias and
> alias-prop CRUD APIs. These are described in detail in the spreadsheet
> linked above, but are summarized in the table below for convenience and
> easier tracking.
> ||API Name||Original Form||Desired Form||Status||Volunteer||
> |-List Alias-|-GET /api/cluster/aliases-|-GET /api/aliases-|-Finished-|-Alex-|
> |Create Alias|POST /api/collections \{"create-alias": \{...\}\}|POST
> /api/aliases {...}|Open|Jason|
> |Delete Alias|POST /api/collections \{"delete-alias": \{...\}\}|DELETE
> /api/aliases/aliasName|Open|Jason|
> |Set Alias Property|POST /api/collections \{"set-alias-property":
> \{...\}\}|PUT /api/aliases/aliasName/properties/propName {"value":
> "someVal"}|Open|Alex|
> |Delete Alias Property|POST /api/collections \{"set-alias-property":
> \{"propName": ""\}\}|DELETE
> /api/aliases/aliasName/properties/propName|Open|Alex|
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
