risdenk commented on code in PR #1407:
URL: https://github.com/apache/solr/pull/1407#discussion_r1151134327


##########
solr/solrj/src/java/org/noggit/JSONUtil.java:
##########
@@ -17,11 +17,19 @@
 package org.noggit;
 
 public class JSONUtil {
+  @SuppressWarnings("MutablePublicArray")
   public static final char[] TRUE_CHARS = new char[] {'t', 'r', 'u', 'e'};
+
+  @SuppressWarnings("MutablePublicArray")
   public static final char[] FALSE_CHARS = new char[] {'f', 'a', 'l', 's', 
'e'};
+
+  @SuppressWarnings("MutablePublicArray")
   public static final char[] NULL_CHARS = new char[] {'n', 'u', 'l', 'l'};
+
+  @SuppressWarnings("MutablePublicArray")
   public static final char[] HEX_CHARS =
       new char[] {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 
'c', 'd', 'e', 'f'};
+
   public static final char VALUE_SEPARATOR = ',';
   public static final char NAME_SEPARATOR = ':';
   public static final char OBJECT_START = '{';

Review Comment:
   addressed and removed the suppresswarnings since it wasn't needed anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to