[
https://issues.apache.org/jira/browse/SOLR-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706204#comment-17706204
]
David Smiley commented on SOLR-16723:
-------------------------------------
SOLR-16079 -- once we modularize the HttpClient based SolrJ SolrClients into
its own module, this mistake won't happen. The little change here could even
be considered part of that.
> Http2SolrClient should not use Apache Http client classes
> ---------------------------------------------------------
>
> Key: SOLR-16723
> URL: https://issues.apache.org/jira/browse/SOLR-16723
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: 9.2
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> @elyograg pointed out that Http2SolrClient has Apache Http Client class in
> use and it shouldn't be needed since Http2SolrClient is Jetty client based.
> https://lists.apache.org/thread/vz6gldbdq0gylncpwsoshfvlvns4kqv8
> Based on some digging, this was introduced here -
> https://github.com/apache/solr/commit/8efed0555898f485d435d53a72cb6441507d81e1#diff-db379c74efc9ff28acfd7571b07e16dbcdaa510783f2bee835b4a288927b5b3d
> It looks like it inadvertently copied from HttpSolrClient.java and used
> ContentType.parse(ct).getMimeType() instead of
> MimeTypes.getContentTypeWithoutCharset(ct).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
