dsmiley commented on code in PR #1513:
URL: https://github.com/apache/solr/pull/1513#discussion_r1155056589
##########
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##########
@@ -219,10 +219,10 @@ public void registerInZk(final SolrCore core, boolean
background, boolean skipRe
} catch (InterruptedException e) {
// Restore the interrupted status
Thread.currentThread().interrupt();
- SolrException.log(log, "", e);
+ log.error("", e);
Review Comment:
```suggestion
log.error("Interrupted", e);
```
BTW I don't get why we had all these logs with empty strings. On the
consuming side as a user, it's weird to see when these exceptions happen.
##########
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##########
@@ -233,7 +233,7 @@ public void registerInZk(final SolrCore core, boolean
background, boolean skipRe
} catch (Exception e1) {
log.error("", e1);
}
- SolrException.log(log, "", e);
+ log.error("", e);
Review Comment:
```suggestion
log.error(e.toString(), e);
```
##########
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##########
@@ -219,10 +219,10 @@ public void registerInZk(final SolrCore core, boolean
background, boolean skipRe
} catch (InterruptedException e) {
// Restore the interrupted status
Thread.currentThread().interrupt();
- SolrException.log(log, "", e);
+ log.error("", e);
} catch (KeeperException e) {
- SolrException.log(log, "", e);
- } catch (AlreadyClosedException e) {
+ log.error("", e);
Review Comment:
```suggestion
log.error("KeeperException", e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
