[
https://issues.apache.org/jira/browse/SOLR-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707662#comment-17707662
]
ASF subversion and git services commented on SOLR-15703:
--------------------------------------------------------
Commit c7f5e85fb46aa727df7120b89f1f64643f1a198e in solr's branch
refs/heads/main from Kevin Risden
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=c7f5e85fb46 ]
SOLR-15703: replace all SolrException.log usage in Solr to just call
log.error(...) directly (#1513)
Co-authored-by: David Smiley <[email protected]>
> replace all SolrException.log usage in Solr to just call log.error(...)
> directly
> --------------------------------------------------------------------------------
>
> Key: SOLR-15703
> URL: https://issues.apache.org/jira/browse/SOLR-15703
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Assignee: Kevin Risden
> Priority: Minor
> Labels: newdev
> Time Spent: 50m
> Remaining Estimate: 0h
>
> There is a lot of code in Solr that uses {{SolrException.log(log, ..)}} as a
> way to ensure that the resulting exception can be "ignored" in tests via
> {{SolrException.ignorePatterns}} / {{SolrTestCaseJ4.ignoreException()}}
> This "test feature" is being cleaned up / replaced in SOLR-15697 so that
> _any_ log message can be "muted" - meaning we don't need this special
> hook/hack – we can replace all calls to {{SolrException.log(log, ..)}} with
> (more efficient) direct calls to {{log.error(..)}}
> But this change isn't trivially to do in a scripted/automated manner –
> notably many of these {{SolrException.log(log, ..)}} use string concatenation
> that needs to be replaced with logging parameterization to pass our
> {{validateLogCalls}} check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
