[
https://issues.apache.org/jira/browse/SOLR-16732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707998#comment-17707998
]
ASF subversion and git services commented on SOLR-16732:
--------------------------------------------------------
Commit 3d852c1238de5df22191eb8bae7bdab55f42ada6 in solr's branch
refs/heads/branch_9x from Kevin Risden
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=3d852c1238d ]
SOLR-16732: misc sonar fixes (#1525)
* Replace String non regex replaceAll with replace
* indexOf to contains or single character indexOf
* Remove NBSP in log message
* unindented if statements missing {}
* Use && instead of & for boolean comparisons
* Replace .equals with isEmpty
> Misc SonarQube findings
> -----------------------
>
> Key: SOLR-16732
> URL: https://issues.apache.org/jira/browse/SOLR-16732
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Minor
> Fix For: main (10.0), 9.3
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I have been running SonarQube against the Solr project and there are some low
> hanging fruit things that can be addressed
> * String non regex replaceAll with replace
> * indexOf -> contains
> * NBSP in log
> * unindented if statements missing {}
> * Use && instead of & for boolean comparisons
> * Replace "".equals with isEmpty
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
