dsmiley commented on code in PR #1537:
URL: https://github.com/apache/solr/pull/1537#discussion_r1156459500
##########
gradle/validation/versions-props-sorted.gradle:
##########
@@ -21,7 +21,7 @@ configure(rootProject) {
task versionsPropsAreSorted() {
doFirst {
def versionsProps = file('versions.props')
- def lines = versionsProps.readLines("UTF-8")
+ def lines = versionsProps.readLines("UTF-8").stream().filter(l ->
!l.startsWith("#")).collect(java.util.stream.Collectors.toList())
Review Comment:
Okay but we also should then remove the generation / overwriting of the file
below as it would wipe out all comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
