[ 
https://issues.apache.org/jira/browse/SOLR-16542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708855#comment-17708855
 ] 

Jason Gerlowski commented on SOLR-16542:
----------------------------------------

I'm very much for the simplification that this ticket represents - maintaining 
both of those approaches longterm for processing and state management is 
insane!  Thanks for picking this up Vinayak!  But I _do_ have a few questions 
for you and David:

# Is there a writeup anywhere of how the DistributedRunner stuff works?  What 
it's benefits are, how it manages ZK state, etc.  Personally I'm coming to this 
effort a little late and am having some trouble getting caught up.
# Would it be safer to make DistributedRunner processing the default for a few 
releases before we remove the option to use the overseer altogether?  Or maybe 
that's the plan here - to only merge this change to 'main', and open a 
different PR for branch_9x that switch the default so that it gets some usage 
before it's the only option in 10.0. 

Lastly:
bq. Even use of DistributedCollectionConfigSetCommandRunner along with its 
executor is debatable ("async" is a dubious need).
Dubious generally?  Or for configset operations specifically?  IMO async is 
absolutely necessary for collection operations. (Imagine doing a shardsplit 
without async!).  And it's definitely nice to have, even for configset 
operations.

> Remove OverseerConfigSetMessageHandler; always do distributed mode
> ------------------------------------------------------------------
>
>                 Key: SOLR-16542
>                 URL: https://issues.apache.org/jira/browse/SOLR-16542
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrCloud
>            Reporter: David Smiley
>            Priority: Major
>              Labels: newdev
>             Fix For: main (10.0)
>
>         Attachments: output5.log, output6.log
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {{distributedCollectionConfigSetExecution}} is a boolean setting on 
> solr.xml/solrCloud that switches *both* Collection API *and* ConfigSet API 
> processing between Overseer based (when =false) vs distributed (when =true).  
> In this issue, remove the Overseer based processing of ConfigSets, thus 
> always use DistributedCollectionConfigSetCommandRunner instead for ConfigSet 
> processing, regardless of the {{distributedCollectionConfigSetExecution}} 
> boolean setting.  Namely, OverseerConfigSetMessageHandler would be removed.  
> The boolean toggle would henceforth only toggle the "collection" aspect of 
> wether to do distributed processing vs Overseer (centralized).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to