hiteshk25 commented on code in PR #1549:
URL: https://github.com/apache/solr/pull/1549#discussion_r1161005048


##########
solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java:
##########
@@ -415,6 +415,13 @@ public void write(JSONWriter jsonWriter) {
     Map<String, Object> map = new LinkedHashMap<>();
     // this serializes also our declared properties
     _allPropsWriter().toMap(map);
+    boolean isLeader = isLeader();

Review Comment:
   Does it make sense to include this in `_allPropsWriter` method? as this 
method included in other method `writeMap` as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to