stillalex commented on code in PR #1504:
URL: https://github.com/apache/solr/pull/1504#discussion_r1163093972
##########
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java:
##########
@@ -331,7 +342,7 @@ protected boolean versionAdd(AddUpdateCommand cmd) throws
IOException {
boolean isReplayOrPeersync =
(cmd.getFlags() & (UpdateCommand.REPLAY | UpdateCommand.PEER_SYNC)) !=
0;
- boolean leaderLogic = isLeader && !isReplayOrPeersync;
+ boolean leaderLogic =
leaderLogicWithVersionIntegrityCheck(isReplayOrPeersync, versionOnUpdate);
Review Comment:
BaseDistributedSearchTestCase#clientFor uses the `clients` list that is
populated via
[SolrTestCaseJ4#getHttpSolrClient](https://github.com/apache/solr/blob/3d02801a565c1083ad899c1cb4b7bcb21754fe04/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java#L2642)
```
return new HttpSolrClient.Builder(url).build();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
