[
https://issues.apache.org/jira/browse/SOLR-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711266#comment-17711266
]
Ilan Ginzburg commented on SOLR-16705:
--------------------------------------
Sure I can do that [~dsmiley]. I think it's the first time I merge a PR that's
not mine, so I'm not familiar with how this works, sorry.
But is it worth back porting such a change? I can see the value as it makes
future backports in same code region easier, but other than that I think Solr
9.x does not need it.
I also agree no need to add a mention in {{CHANGES.txt}} (which is too bad for
[~pierre.salagnac], he only removed code lines so his name will not appear
anywhere nor in git blame :))
> Useless Zookeeper checks in shard leader election
> -------------------------------------------------
>
> Key: SOLR-16705
> URL: https://issues.apache.org/jira/browse/SOLR-16705
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Affects Versions: 9.0, 9.1
> Reporter: Pierre Salagnac
> Priority: Minor
> Fix For: main (10.0)
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> After a Solr node restart, shard leader election code has specific calls to
> Zookeeper to wait for all replicas to join the election.
> This code is useless when joining leader election for another reason than
> node restart.
> (in class ShardLeaderElectionContext, call to method
> areAllReplicasParticipating() is useless and we ignore the returned value).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
