vinayakphegde commented on code in PR #1557:
URL: https://github.com/apache/solr/pull/1557#discussion_r1165081964
##########
solr/core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java:
##########
@@ -695,7 +695,7 @@ protected Object doHighlightingByHighlighter(
// Try term vectors, which is faster
// note: offsets are minimally sufficient for this HL.
- final Fields tvFields = schemaField.storeTermOffsets() ?
reader.getTermVectors(docId) : null;
+ final Fields tvFields = schemaField.storeTermOffsets() ?
reader.termVectors().get(docId) : null;
Review Comment:
we are only using the `doHighlightingByHighlighter` method here:
https://github.com/apache/solr/blob/67be5d0b01bd653f7315b93af728d2259bc9daf2/solr/core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java#L572
So, won't it work if we pass `reader.termVectors()` instead of `reader`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
