HoustonPutman opened a new pull request, #1563: URL: https://github.com/apache/solr/pull/1563
https://issues.apache.org/jira/browse/SOLR-16748 This PR finally takes a look at what we actually need to do in the official Dockerfile and how we should allow customization (A TODO that hadn't been addressed since the migration). - [ ] Check SHA even if GPG isn't checked - [ ] Remove all download servers except for the closer script (`https://www.apache.org/dyn/closer.lua`) - [ ] Only option for customizing the download location is via the `SOLR_DOWNLOAD_SERVER` arg. This must accept requests to `<version>/solr-<version>(-slim).tgz(.asc)`. - [ ] Only check GPG if the url contains `apache.org`, otherwise there is very little point in verifying the signature. (especially since mirrors are no longer a thing in apache). - [ ] Cleanup GPG logic, so that it only executes when GPG checking is enabled. - [ ] Make sure this works with the `gradle testBuildDockerfileOfficial` - [ ] Make sure that the release wizard instructions will work here. Big wins: The file is less complex, and there is only one place that the download url can come from, and the tests (and RC process) will ensure the GPG check succeeds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
