aruggero opened a new pull request, #1586: URL: https://github.com/apache/solr/pull/1586
https://issues.apache.org/jira/browse/SOLR-16759 # Description Currently, there is no possibility of deciding how many features to log. It would be useful to give the user the ability to decide if to print all the features of the store or only the features used by the model. Suppose to execute a query with both logging and reranking, where the logging store is the same as the model store. Suppose the model store contains 200 features while the model uses just half of them. The logging will always consider all the 200 features of the store. There is no possibility of printing only the 100 features used by the model. # Solution An external parameter _logAll_ has been added to the features transformer in order to give the user the possibility to choose how many features to log. The new parameter has been added to: - solr/modules/ltr/src/java/org/apache/solr/ltr/FeatureLogger.java - solr/modules/ltr/src/java/org/apache/solr/ltr/CSVFeatureLogger.java # Tests Several tests have been added into org/apache/solr/ltr/feature/TestFeatureLogging.java We add one test for each feature logger store - logAll parameter combination. We checked that the set of features returned is the expected on (all the features in the store or only the model features). # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [X] I have added tests for my changes. - [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
