[
https://issues.apache.org/jira/browse/SOLR-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716363#comment-17716363
]
ASF subversion and git services commented on SOLR-7609:
-------------------------------------------------------
Commit 1d8781d61746d0b9c6dbf3cc2b5c9ecd4f90537b in solr's branch
refs/heads/main from Alex Deparvu
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=1d8781d6174 ]
SOLR-7609: Validate the version is present on follower replicas when adding
documents (#1504)
* Add the version check on additions to fail in case we are not leader and
version = 0. (to match delete flows)
* Change error status from BAD_REQUEST to INVALID_STATE to allow for retries.
* Remove a 'cmd' variable - this is just minor readability refactoring, I tried
to avoid changing the code as much as possible
* Update the ShardSplitTest to keep track of exceptions happening during the
concurrent adds and deletes and fail if needed.
*Fix bad null validation
> ShardSplitTest NPE
> ------------------
>
> Key: SOLR-7609
> URL: https://issues.apache.org/jira/browse/SOLR-7609
> Project: Solr
> Issue Type: Bug
> Reporter: Steven Rowe
> Priority: Minor
> Attachments: ShardSplitTest.NPE.log
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> I'm guessing this is a test bug, but the seed doesn't reproduce for me (tried
> on the same Linux machine it occurred on and on OS X):
> {noformat}
> [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=ShardSplitTest
> -Dtests.method=test -Dtests.seed=9318DDA46578ECF9 -Dtests.slow=true
> -Dtests.locale=is -Dtests.timezone=America/St_Vincent -Dtests.asserts=true
> -Dtests.file.encoding=US-ASCII
> [junit4] ERROR 55.8s J6 | ShardSplitTest.test <<<
> [junit4] > Throwable #1: java.lang.NullPointerException
> [junit4] > at
> __randomizedtesting.SeedInfo.seed([9318DDA46578ECF9:1B4CE27ECB848101]:0)
> [junit4] > at
> org.apache.solr.cloud.ShardSplitTest.logDebugHelp(ShardSplitTest.java:547)
> [junit4] > at
> org.apache.solr.cloud.ShardSplitTest.checkDocCountsAndShardStates(ShardSplitTest.java:438)
> [junit4] > at
> org.apache.solr.cloud.ShardSplitTest.splitByUniqueKeyTest(ShardSplitTest.java:222)
> [junit4] > at
> org.apache.solr.cloud.ShardSplitTest.test(ShardSplitTest.java:84)
> [junit4] > at
> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsFixedStatement.callStatement(BaseDistributedSearchTestCase.java:960)
> [junit4] > at
> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:935)
> [junit4] > at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Line 547 of {{ShardSplitTest.java}} is:
> {code:java}
> idVsVersion.put(document.getFieldValue("id").toString(),
> document.getFieldValue("_version_").toString());
> {code}
> Skimming the code, it's not obvious what could be null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
