janhoy commented on code in PR #1593:
URL: https://github.com/apache/solr/pull/1593#discussion_r1181120304
##########
solr/webapp/web/js/angular/controllers/cloud.js:
##########
@@ -198,10 +194,13 @@ var nodesSubController = function($scope, Collections,
System, Metrics) {
for (var replicaName in replicas) {
var core = replicas[replicaName];
core.name = replicaName;
- core.label = coreNameToLabel(core['core']);
+ core.replica = core['core'].replace(/.*_(replica_.*)$/, '\$1');
core.collection = collection.name;
core.shard = shard.name;
core.shard_state = shard.state;
+ core.label = core['collection'] + "_"
+ + (core['shard'] + "_").replace(/shard(\d+)_/, 's\$1')
+ + core['replica'].replace(/replica_?[ntp]?(\d+)/, 'r\$1');
Review Comment:
The label is for display purpose only. There is no before/after. This code
produces exactly same display label as previously, but now also works for the
custom shard names in implicit mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
