janhoy commented on code in PR #1603:
URL: https://github.com/apache/solr/pull/1603#discussion_r1181313208
##########
solr/core/src/test/org/apache/solr/request/TestRemoteStreaming.java:
##########
@@ -48,14 +48,17 @@ public class TestRemoteStreaming extends SolrJettyTestBase {
@BeforeClass
public static void beforeTest() throws Exception {
+ System.setProperty("solr.enableRemoteStreaming", "true");
Review Comment:
Should add a new test case here to verify streaming fails when sysprop is
false.
##########
solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java:
##########
@@ -86,7 +86,11 @@ public class SolrRequestParsers {
private final HashMap<String, SolrRequestParser> parsers = new HashMap<>();
private final boolean enableRemoteStreams;
+ public final boolean enableRemoteStreamsAtNodeLevel =
+ Boolean.parseBoolean(System.getProperty("solr.enableRemoteStreaming",
"false"));
private final boolean enableStreamBody;
+ public final boolean enableStreamBodyAtNodeLevel =
+ Boolean.parseBoolean(System.getProperty("solr.enableStreamBody",
"true"));
Review Comment:
Do we need two different sysprops here? This `solr.enableStreamBody` is not
documented in refGuide. Can't the same `solr.enableRemoteStreaming` be used for
all remote streaming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
