markrmiller commented on PR #57: URL: https://github.com/apache/solr-sandbox/pull/57#issuecomment-1530805190
Nice, I was probably just going to hack that in there per site, MDC is a good call I think. The only thing I haven’t checked (I’m looking at my phone on the way to the grocery store) is if request.getCollection is sufficient for all cases or if you should check the params as well. I have a memory suspicion that it could either be passed as an arg and live as a field, or be shoved in the params, and that getCollection only return the former. Wouldn’t swear on it though. Outside making sure that’s not a problem, lgtm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
