gerlowskija commented on PR #57:
URL: https://github.com/apache/solr-sandbox/pull/57#issuecomment-1531284682
> is [...] request.getCollection [...] sufficient for all cases or if you
should check the params as well.
It looks like `request.getCollection` only looks at the params actually. The
impl is just:
```
public String getCollection() {
return getParams() == null ? null : getParams().get("collection");
}
```
...which does seem a little suspect to me generally. But in our case here I
think it should actually be right. I'm not seeing the collection referenced
anywhere, going all the way back to
`KafkaCrossDcConsumer.pollAndProcessRequests` where we create these
UpdateRequests. So if it's coming through at all (which it definitely is) it
must be in the params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
