janhoy commented on code in PR #1622:
URL: https://github.com/apache/solr/pull/1622#discussion_r1186022838
##########
solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java:
##########
@@ -60,7 +60,6 @@ public class ResponseBuilder {
public boolean doExpand;
public boolean doStats;
public boolean doTerms;
- public boolean doAnalytics;
Review Comment:
Thanks for commenting on this. I was surprised to find analytics specific
vars in ResponseBuilder, and could not find any other use of these, so I
removed them. If someone were to package the component as a package and
maintain it on GitHub, it would be nice if this was more generic.
From SOLR-13511 I understand that you can provide your own custom
ResponseBuilder if you own the SearchHandler. Fair enough, could be part of
that plugin package.
Or would it be possible to have some kind of `Map<Sting,Object>
responseContext` structure on ResponseBuilder where plugins could register
arbitrary data? I'm on thin ice here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
