epugh commented on code in PR #1600:
URL: https://github.com/apache/solr/pull/1600#discussion_r1188478363
##########
solr/bin/solr:
##########
@@ -746,7 +750,6 @@ function run_tool() {
# get status about any Solr nodes running on this host
function get_status() {
- CODE=4
Review Comment:
I've added https://issues.apache.org/jira/browse/SOLR-16794 to track
properly doing Exit codes everywhere (and we'll want to bats test them!), so
I'm going to call this PR good to go and merge it before it gets more stale?
Is that cool @risdenk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
