renatoh commented on code in PR #1570:
URL: https://github.com/apache/solr/pull/1570#discussion_r1188697934
##########
solr/solrj/src/java/org/apache/solr/common/params/ModifiableSolrParams.java:
##########
@@ -175,6 +177,18 @@ public boolean remove(String name, String value) {
// ----------------------------------------------------------------
// ----------------------------------------------------------------
+ public static void setShardAttributesToParams(
+ int purpose, String shard, ModifiableSolrParams params) {
Review Comment:
true, I did not realize an instance of ModifiableSolrParams is present at
the place where the method is called.
I have added a unit test validating the code, please have a look.
Also I have made two changes to the method, please have a look at me know if
this makes sense to you.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
