[
https://issues.apache.org/jira/browse/SOLR-16784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721395#comment-17721395
]
Gus Heck commented on SOLR-16784:
---------------------------------
As I understand it BadApples are tests that test something important but are
flaky. They are important tests that need to be fixed, but an accumulation of
flakey tests will make it impossible to move forward with changes because every
individual developer needs to do their own tracking and analysis and run
multiple times to see if any of the flakey tests are actual real failures.
BadApple is a community acknowledgement that this test fails frequently, and
thus avoids the massive duplication of effort.
IIRC we settled on associating the BadApple annotation with a Jira to make sure
that these *temporary* annotations were not forgotten. If we close the
associated issue, then we need some other way of tracking tests that are flaky
and in need of fixing.
If the test is so bad that it is impossible to fix it, or it is testing
something unimportant we don't need a BadApple, we need to delete the test.
> Frequent failing CollectionReloadTest
> -------------------------------------
>
> Key: SOLR-16784
> URL: https://issues.apache.org/jira/browse/SOLR-16784
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Jan Høydahl
> Assignee: Eric Pugh
> Priority: Major
> Fix For: main (10.0), 9.3
>
> Attachments: Skjermbilde 2023-05-03 kl. 09.36.42.png
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The CollectionReloadTest fails frequently:
> !Skjermbilde 2023-05-03 kl. 09.36.42.png|width=800!
> Reproduces without a seed
> {code:java}
> ./gradlew :solr:core:test --tests
> "org.apache.solr.cloud.api.collections.CollectionReloadTest.testCreateReloadDeleteAllTlog"
> -Ptests.jvms=8 -Ptests.jvmargs="-XX:TieredStopAtLevel=1 -XX:+UseParallelGC
> -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" {code}
> I'll BadApple it
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
